Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(validation): Fix arguments validation after updating the class-validator #1404

Closed
wants to merge 1 commit into from
Closed

fix(validation): Fix arguments validation after updating the class-validator #1404

wants to merge 1 commit into from

Conversation

kolpakov-p
Copy link

In order to get rid of CVE-2019-18413 present in old versions of class-validator. There was a bug in the old version of class-validator, which lead to run validation with forbidUnknownValues enabled. So, to return the old behavior, enabling it explicitly now.

@AmineFouzai
Copy link

Agree I had to set validate:false in Apollo server configuration to avoid the unknown or undefined error that it throws after testing apis Wich completely removes the use of class-validator package . Thnx this has to be merged asap @kolpakov-p

@MichalLytek
Copy link
Owner

@MedAmineFouzai You don't need to disable, you can set global options for type-graphql:
#1397 (comment)

@kolpakov-p
Copy link
Author

I’m closing the PR due to the way to fix the issue is already exists (mentioned by MichaLytek above). Thank you!

@kolpakov-p kolpakov-p closed this Jan 3, 2023
@MichalLytek MichalLytek added Wontfix ❌ This will not be worked on Community 👨‍👧 Something initiated by a community Bugfix 🐛 🔨 PR that fixes a known bug labels Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix 🐛 🔨 PR that fixes a known bug Community 👨‍👧 Something initiated by a community Wontfix ❌ This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants