Merge pull request #80 from MichaelYuhe/fix/type-check

feat: add type check

.github/workflows/build.yml

@@ -33,6 +33,9 @@ jobs:
       - name: Lint
         run: nr style
 
+      - name: Type check
+        run: nr typecheck
+
       - name: Build
         run: nr build
 

package.json

@@ -7,6 +7,7 @@
     "prepare": "husky install",
     "dev": "vite build --watch",
     "build": "vite build",
+    "typecheck": "tsc --noEmit",
     "style": "prettier --check \"src/**/*.{ts,tsx}\"",
     "style:fix": "prettier --write \"src/**/*.{ts,tsx}\""
   },

src/background.ts

@@ -20,7 +20,7 @@ chrome.storage.local.get("types", (result) => {
 
 const windowGroupMaps: { [key: number]: Map<string, number> } = {};
 
-chrome.runtime.onMessage.addListener((message, sender, sendResponse) => {
+chrome.runtime.onMessage.addListener((message) => {
   chrome.storage.local.get("types", (resultStorage) => {
     if (resultStorage.types) {
       types = resultStorage.types;
@@ -159,7 +159,7 @@ async function handleNewTab(tab: chrome.tabs.Tab) {
 }
 
 async function handleTabUpdate(
-  tabId: number,
+  _tabId: number,
   changeInfo: chrome.tabs.TabChangeInfo,
   tab: chrome.tabs.Tab
 ) {
@@ -185,7 +185,7 @@ async function handleTabUpdate(
 
 chrome.tabs.onCreated.addListener(handleNewTab);
 chrome.tabs.onUpdated.addListener(handleTabUpdate);
-chrome.tabs.onDetached.addListener((tabId, detachInfo) => {
+chrome.tabs.onDetached.addListener((_tabId, detachInfo) => {
   const windowId = detachInfo.oldWindowId;
   if (
     windowGroupMaps.hasOwnProperty(windowId) &&

src/popup.tsx

@@ -65,7 +65,7 @@ const Popup = () => {
   };
 
   const enableAutoPosition = () => {
-    setIsAutoPosition((isAutoGroupPosition) => {
+    setIsAutoPosition(() => {
       setStorage("isAutoPosition", !isAutoPosition);
       return !isAutoPosition;
     });
@@ -140,8 +140,8 @@ const Popup = () => {
 
             <button
               disabled={!newType}
-              className="rounded-md w-fit bg-primary/lg px-2.5 py-1.5 text-sm font-semibold 
-            text-white shadow-sm hover:bg-primary focus-visible:outline focus-visible:outline-2 
+              className="rounded-md w-fit bg-primary/lg px-2.5 py-1.5 text-sm font-semibold
+            text-white shadow-sm hover:bg-primary focus-visible:outline focus-visible:outline-2
             focus-visible:outline-offset-2 disabled:bg-primary/sm"
             >
               Add
@@ -178,7 +178,7 @@ const Popup = () => {
       <div className="flex items-center gap-x-4">
         <button
           disabled={!openAIKey || !types || !types.length}
-          className="inline-flex items-center rounded-md bg-primary/lg px-2.5 py-1.5 text-sm font-semibold 
+          className="inline-flex items-center rounded-md bg-primary/lg px-2.5 py-1.5 text-sm font-semibold
         text-white shadow-sm hover:bg-primary focus-visible:outline cursor-pointer
         focus-visible:outline-2 focus-visible:outline-offset-2"
           onClick={getAllTabsInfo}
@@ -188,7 +188,7 @@ const Popup = () => {
         </button>
 
         <button
-          className="inline-flex items-center rounded-md bg-primary/lg px-2.5 py-1.5 text-sm font-semibold 
+          className="inline-flex items-center rounded-md bg-primary/lg px-2.5 py-1.5 text-sm font-semibold
         text-white shadow-sm hover:bg-primary focus-visible:outline cursor-pointer
         focus-visible:outline-2 focus-visible:outline-offset-2"
           onClick={ungroup}