Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let the streamed downloader handle HTTP status codes #836

Merged
merged 1 commit into from
Sep 28, 2024
Merged

Let the streamed downloader handle HTTP status codes #836

merged 1 commit into from
Sep 28, 2024

Conversation

MichaelSasser
Copy link
Owner

fixes #835

Affected Handlers

  • API

Description of Change

  • Make handler.api.streamed_download handle HTTP status codes

Checklist

  • Have you documented your changes?
  • (*) Have you created an issue first?
  • (*) Have you checked to ensure there aren't other open Pull Requests for
    the same update/change?
  • (*) Have you created a newsfragment in ./news/?
  • (*) Have you lint your code locally before submission?
  • (*) Did you ran tox and everything passed?
  • (*) I haven't added any dependencies without approval.

I have read and accept the:

@MichaelSasser
fix: Break out the the sync status code handler from _request of th…
4d93493 
…e API handler into `handle_sync_response_status_code` and re-use it in `streamed_download`
@MichaelSasser MichaelSasser self-assigned this Sep 28, 2024
@MichaelSasser MichaelSasser merged commit 6891bc4 into develop Sep 28, 2024
5 checks passed
@MichaelSasser MichaelSasser deleted the feature/streamed-download-handle-invalid-token branch September 28, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MichaelSasser MichaelSasser

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

streamed_handler should handle http error codes
1 participant
@MichaelSasser