Ikhlas - AsTETH - AAVE - Certora #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updates |
1 similar comment
|
Updates |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My contributions within AStETH.spec is from Line 569.
Link to the tests: https://prover.certora.com/output/25300/a17904670f7610f30fb1/?anonymousKey=de6d85238456ce6d7216d65b3acd6cb2f4bbf697
Following tests had a violation:
Justification and reasoning for each:
nonrevertOfBurn - predefined example - not touched
checkingcorrectChainID - to check ChainID when running actual program (cannot be run with prover)
checkingsetDecimalsIsCorrect - to check Decimals when running actual program (cannot be run with prover)
checkingBalanceOfFunctionLimits - Assert to check balance is lower than supply is failing - needs to be verified
checkingscaledBalanceOfFunctionLimits - Assert to check balance is lower than supply is failing - needs to be verified
checkinginternalBalanceOfFunctionLimits - Assert to check balance is lower than supply is failing - needs to be verified
checkinggetScaledUserBalanceAndSupplyFunctionLimits - Assert to check balance is lower than supply is failing - needs to be verified
CheckPermitFunction - Assert to compare Allowance before and after is failing; possibly need to set initial allowance as 0
checkingscaledBalanceOfFunctionLimits2 Assert to check balance is lower than supply is failing - needs to be verified
totalSupplyGESingleUserBalance - predefined example - not touched