Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chunked local evaluation #429

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

GaetanLepage
Copy link
Contributor

See NixOS/nixpkgs#356023

  • default.nix: python3.pkgs -> python3Packages
  • chunked eval

@infinisil
Copy link

Also check out https://github.com/tweag/nixpkgs/tree/gha-eval/ci/eval#nixpkgs-ci-evaluation, that's the latest state of the above-linked PR

@Mic92
Copy link
Owner

Mic92 commented Nov 20, 2024

Eval got merged. We can also start using the json.

@JohnRTitor
Copy link

I would add that instead of fetching @ofborg's evaluation result, if available it should fetch our new CI evaluator. https://github.com/NixOS/nixpkgs/actions/runs/11947073470/job/33302502332?pr=357763

@Mic92
Copy link
Owner

Mic92 commented Nov 21, 2024

I would add that instead of fetching @ofborg's evaluation result, if available it should fetch our new CI evaluator. https://github.com/NixOS/nixpkgs/actions/runs/11947073470/job/33302502332?pr=357763

So much todo and so little time :). If you want to take a step at it, I wouldn't mind. We can even check for both ofborg and the github one so it also works for older PRs that haven't been updated. However we don't have that json for master yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants