Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix/review_shell.nix: use ignoreFileOutputs whenever available #427

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ShamrockLee
Copy link

@ShamrockLee ShamrockLee commented Nov 5, 2024

This PR depends on NixOS/nixpkgs#353752 and fixes #408 partially.

Cc: @corngood

@Mic92
Copy link
Owner

Mic92 commented Nov 5, 2024

Thanks. Looks good.

@ShamrockLee
Copy link
Author

Considering that the single-file-output error is a potential way to enforce the correctness of meta.outputsToInstall, we may want to preserve such behavior while proving options to ignore those single-file outputs.

I prepared the implementation to support nixpkgs-review --ignore-single-file-outputs locally. I could push it up if we agree that this should be supported through a flag.

@Mic92, what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review shell fails when there are single-file inputs.
2 participants