-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag to build package passthru.tests
#397
base: master
Are you sure you want to change the base?
Conversation
Until now, failed tests would not be reported separately and simply shown in the "tests build" list.
build_passthru_tests=build_passthru_tests, | ||
) | ||
changed_packages = set( | ||
changed_attrs[path].name for path in changed_attrs.keys() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late reply. I think because of the potential large memory consumption of nixos tests, we need to evaluate them isolation as they will otherwise make the build potentially go out of memory, i.e. if you try to have a large package set rebuild.
Therefore I would suggest to evaluate those packages ahead of time i.e. using nix-instantiate
and add them to the final nix build
. Of course a better design would be some sort of pipe-lining where already evaluated packages gets build as the rest of the evaluation is still in progress. But this probably requires bigger refactorings and could implemented at a later point similar to nix-fast-build. When using nix-instantiate also add a gcroot with --add-root
to make sure that derivations are not garbage collected before hand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe at first we could do this way but warn about this possible problem and then address it in a follow up PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's a good idea to just merge it like that as going out of memory can also causes the users system to crash in some cases i.e. crashing their wayland compositor.
This PR adds a
--tests
flag to buildpassthru.tests
for all packages, as discussed in #77.The tests to be build can be filtered with
-p
,-P
and similar, like all other packages.Since they are classified as tests, they can also be enabled individually with
-p
, without specifying--tests
:Fixes: #77