argcomplete: fix auto-generated shell-completions in postInstall #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at f2c5167 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Result after this change (zsh, but tested in bash and also makes them work but less nice but also unconfigured bash compared to personal zsh-setup):
I wen the wrong way first and tried to setup/make argcomplete global-setup work with NixOS/wrappers by resolving the last line and redirecting the resolution but later figured out that's not needed.
I looked through nixpkgs and only found one other package using the full path (https://github.com/search?q=repo%3ANixOS%2Fnixpkgs+register-python-argcomplete+%24out&type=code) and enabling
_ARC_DEBUGmade me realize the registered completion does not trigger as it never (except you copy the full path to nix-store) matches.If this is accepted I can also provide a nixpkgs-pr with reference to here ✌🏻