add pylint configuration #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artturin
force-pushed
the
improveconfigs
branch
2 times, most recently
from
1b14e34 to
bc9f5ad
Compare
but not tests yet
Flake lock file updates:
• Updated input 'nixpkgs':
'github:NixOS/nixpkgs/e08e100b0c6a6651c3235d1520c53280142d9d5f' (2023-08-05)
→ 'github:NixOS/nixpkgs/12bdeb01ff9e2d3917e6a44037ed7df6e6c3df9d' (2023-10-15)
move the strict enablement to the pyproject.toml so disabling checks works correctly because `--strict` takes precedence over the file Checking everything was disabled in 60205b9 due to (seemingly) a bug
remove redundant enables
```
--strict Strict mode; enables the following flags: --warn-unused-configs, --disallow-any-generics, --disallow-
subclassing-any, --disallow-untyped-calls, --disallow-untyped-defs, --disallow-incomplete-defs, --check-
untyped-defs, --disallow-untyped-decorators, --warn-redundant-casts, --warn-unused-ignores, --warn-return-any,
--no-implicit-reexport, --strict-equality, --strict-concatenate
```
Artturin
force-pushed
the
improveconfigs
branch
from
bc9f5ad to
21e9292
Compare
|
Will fix more lints in a separate PR |
|
Ruff seems to support some pylint lints under |
Mic92
reviewed
Oct 19, 2023
| @@ -297,7 +297,7 @@ def nix_build( | |||
| def write_shell_expression( | |||
| filename: Path, attrs: list[str], system: str, nixpkgs_config: Path | |||
| ) -> None: | |||
| with open(filename, "w+") as f: | |||
| with open(filename, "w+", encoding="utf-8") as f: | |||
There was a problem hiding this comment.
What happens if you don't specify encoding?
There was a problem hiding this comment.
https://pylint.pycqa.org/en/latest/user_guide/messages/warning/unspecified-encoding.html
It is better to specify an encoding when opening documents. Using the system default implicitly can create problems on other operating systems. See https://peps.python.org/pep-0597/
|
I guess it doesn't hurt.. checking should be still fast enough |
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at c20b63f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
but not tests yet