Skip to content

Commit

Permalink
Make the review-shell purer
Browse files Browse the repository at this point in the history
The purpose of this `env` is to add the binaries to the `PATH`.

The benefit of making it purer is that unwrapped programs missing
dependencies may fail.

As a added benefit this dramatically reduces the collision warnings from `buildEnv`

`warning: collision between '/nix/store/82icynaidvzyic2g349cqi4p9a5d4aa2-vimplugin-ai.vim-2023-10-03/doc/tags' and '/nix/store/qc4bdwi6zhk4r1vzbcxrnwrrjnm33a6g-vimplugin-CheckAttach-2019-05-08/doc/tags'`
  • Loading branch information
Artturin committed Oct 20, 2023
1 parent cfae4ff commit 760e7d1
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions nixpkgs_review/nix.py
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,7 @@ def write_shell_expression(
env = buildEnv {
name = "env";
inherit paths;
pathsToLink = [ "/bin" ];
ignoreCollisions = true;
};
in (import ./nixpkgs { }).mkShell {
Expand Down

0 comments on commit 760e7d1

Please sign in to comment.