Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mojave-style tabs do not handle window changing focus properly #69

Open
ychin opened this issue Nov 24, 2018 · 2 comments
Open

Mojave-style tabs do not handle window changing focus properly #69

ychin opened this issue Nov 24, 2018 · 2 comments

Comments

@ychin
Copy link

ychin commented Nov 24, 2018

I'm just trying out the demo, but Mojave tabs don't seem to update their colors properly when the window gains/loses focus. You have to manually move the cursor over the tabs to update their colors. The other styles seem to handle it properly.
@barijaona barijaona mentioned this issue Dec 19, 2018
Closed
@barijaona
Copy link
Collaborator

I see similar problems with Yosemite style.
If you hover over the tabs while the window is in background, then switch the window to foreground, the colors do not update correctly.

@barijaona
Copy link
Collaborator

When the window gains/loses focus, MMMojaveTabStyle's drawBezelOfTabBarView:inRect: method is only called once (for the first tab only).

barijaona added a commit to barijaona/MMTabBarView that referenced this issue Dec 25, 2018
@barijaona
Fix problems with changes of window having focus
9460726 
Issue MiMo42#69 : some styles (Mojave and Yosemite) did not
update properly their colors when the window gains/loses focus.
@barijaona barijaona mentioned this issue Dec 25, 2018
Merged
barijaona added a commit to barijaona/MMTabBarView that referenced this issue Dec 25, 2018
@barijaona
Fix problems with changes of window having focus
eb9e91f 
Issue MiMo42#69 : some styles (Mojave and Yosemite) did not
update properly their colors when the window gains/loses focus.
barijaona added a commit to barijaona/MMTabBarView that referenced this issue Dec 26, 2018
@barijaona
Fix problems with changes of window having focus
5466759 
Issue MiMo42#69 : some styles (Mojave and Yosemite) did not
update properly their colors when the window gains/loses focus.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@barijaona @ychin