Merge upstream #10
Merge upstream #10
Conversation
…rch-lightning >= 2.1
- Move all data dimensionality constants to constants.py - Add note about ccai_paper_2023 branch - Create metrics module with common interface - Introduce nll and crps_gauss metrics, also available as losses - Introduce output_std option to let models output std.-devs. - Change validation metric from mae to rmse - Change definition of rmse to take sqrt after spatial averaging only - Add possibility to watch specific metrics and log as scalars, specified in constants.py
- Added linting and formatting using pre-commits - Trigger pre-commit on main-branch push - Change line length to 80 - Fixing existing formatting issues - Added section about development with pre-commits --------- Co-authored-by: joeloskarsson <[email protected]>
- Make github action env completely match installation instructions in readme - Configure duplicate code threshold to be less harsh
|
@joeloskarsson Just wanted to let you know that I have prepared myself for our co-coding session in May 💻. Our main-branch is up-to-date with yours 🤝 Thanks again for implementing the pre-commits! |
| xarray>=2024.1.1 | ||
| tueplots>=0.0.8 | ||
| plotly>=5.15.0 | ||
| # for dev |
There was a problem hiding this comment.
normally you would do a two-stepped approach here where you specify the two requirements in two files. See here for example:
https://github.com/MeteoSwiss-APN/nwp_log_mining/blob/main/requirements/requirements_build.txt
https://github.com/MeteoSwiss-APN/nwp_log_mining/blob/main/requirements/requirements_run.txt
There was a problem hiding this comment.
This is directly defined by upstream. If you have strong feelings about it I can create a PR? otherwise I would suggest to use the conda within MeteoSwiss as it is easier and consistent with our common practices.
There was a problem hiding this comment.
ah I see. Then this is clearly out of scope of this PR.
I think I can create a PR upstream then
Fix upstream merge branch
Merge upstream Conflicts: .github/workflows/pre-commit.yml .gitignore .pre-commit-config.yaml README.md create_grid_features.py create_mesh.py create_parameter_weights.py create_static_features.py create_zarr_archive.py environment.yml helper.py neural_lam/constants.py neural_lam/models/ar_model.py neural_lam/models/base_graph_model.py neural_lam/models/base_hi_graph_model.py neural_lam/rotate_grid.py neural_lam/utils.py neural_lam/vis.py neural_lam/weather_dataset.py plot_graph.py pyproject.toml requirements.txt slurm_eval.sh slurm_train.sh train_model.py
This PR consists of a merge with upstream/main including reformating and linting using new pre-comits. I suggest to review this PR by doing the following (instead of checking each line change):
slurm_train.shslurm_eval.shIf all runs through smoothly without errors, we can merge. I am handling this a bit like an initial commit.