Skip to content
This repository has been archived by the owner on Apr 22, 2024. It is now read-only.

ci: bundle as part of build-lint-test workflow #455

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

legobeat
Copy link
Contributor

this adds a step running yarn bundle to CI, ensuring that regressions are not introduced affecting the bundles.

@legobeat legobeat changed the title ci: run bundle as part of build-lint-test workflow ci: bundle as part of build-lint-test workflow Oct 13, 2023
@legobeat legobeat marked this pull request as ready for review October 13, 2023 06:28
@legobeat legobeat requested a review from a team as a code owner October 13, 2023 06:28
@legobeat legobeat requested a review from kumavis October 17, 2023 07:31
@legobeat
Copy link
Contributor Author

legobeat commented Oct 18, 2023

This was passing until the merge of #455 , which introduced:

$ mkdir -p ./dist && yarn bundle-engine && yarn bundle-zero
$ browserify -s ProviderEngine -e index.js -t [ babelify --presets [ @babel/preset-env ] ] > dist/ProviderEngine.js
SyntaxError: Unexpected token (329:36) while parsing /home/runner/work/web3-provider-engine/web3-provider-engine/node_modules/@ethereumjs/util/dist/bytes.js while parsing file: /home/runner/work/web3-provider-engine/web3-provider-engine/node_modules/@ethereumjs/util/dist/bytes.js
    at DestroyableTransform.end [as _flush] (/home/runner/work/web3-provider-engine/web3-provider-engine/node_modules/insert-module-globals/index.js:114:21)
    at DestroyableTransform.prefinish (/home/runner/work/web3-provider-engine/web3-provider-engine/node_modules/through2/node_modules/readable-stream/lib/_stream_transform.js:138:10)
    at DestroyableTransform.emit (node:events:517:28)
    at prefinish (/home/runner/work/web3-provider-engine/web3-provider-engine/node_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:619:14)
    at finishMaybe (/home/runner/work/web3-provider-engine/web3-provider-engine/node_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:627:5)
    at endWritable (/home/runner/work/web3-provider-engine/web3-provider-engine/node_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:638:3)
    at Writable.end (/home/runner/work/web3-provider-engine/web3-provider-engine/node_modules/through2/node_modules/readable-stream/lib/_stream_writable.js:594:41)
    at DestroyableTransform.onend (/home/runner/work/web3-provider-engine/web3-provider-engine/node_modules/through2/node_modules/readable-stream/lib/_stream_readable.js:577:10)
    at Object.onceWrapper (node:events:631:28)
    at DestroyableTransform.emit (node:events:529:35)
    at endReadableNT (/home/runner/work/web3-provider-engine/web3-provider-engine/node_modules/through2/node_modules/readable-stream/lib/_stream_readable.js:1010:12)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Copy link
Member

@kumavis kumavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice

@legobeat legobeat merged commit 4edf2ba into MetaMask:main Oct 18, 2023
5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants