Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New EOS Wallet #949

Merged
merged 3 commits into from
Dec 12, 2024
Merged

New EOS Wallet #949

merged 3 commits into from
Dec 12, 2024

Conversation

khanti42
Copy link
Collaborator

@khanti42 khanti42 commented Nov 25, 2024

Closes: #950

@khanti42 khanti42 marked this pull request as ready for review November 26, 2024 09:52
@khanti42 khanti42 requested review from Montoya and a team as code owners November 26, 2024 09:52
Montoya
Montoya previously approved these changes Dec 3, 2024
@khanti42
Copy link
Collaborator Author

khanti42 commented Dec 5, 2024

Please hold off on merging for now. Here’s the update the builder is currently working on:

They are updating the Snap to change how index numbers are used during key derivation. The update won’t impact MetaMask’s security model or functionality, but it will enhance EOS account security and permissions by:

  • Using the derived key from index 0 as the “owner” key of the account.
  • Reserving index ≥ 1 for the “active” key or any additional permissions the user adds.
  • Restricting signing transactions to keys with index ≥ 1, leaving the index 0 key as a potential account recovery path for users.

This adjustment sets up the Snap and users for future features that leverage EOS’s unique account and permission structures.

cc: @mario-christopher , @Montoya

Copy link
Member

@FrederikBolding FrederikBolding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking based on the comment above

@khanti42
Copy link
Collaborator Author

khanti42 commented Dec 9, 2024

Unblocking. Builder pushed the required fixes and are ready for allowlisting.

Message Received From builder:

Alright, these changes are now complete and we’ve published a 1.1.0 version of the Snap. Creation via the updated page at the URL below has been tested and all seems to be working as intended!
https://unicove.com/en/eos/metamask

The one thing this is going to do is prevent previously created accounts from logging in, due to the indexes changing. That’s why they wanted to get it published before any real users started using the snap. Considering only our two teams have ever used this system, this shouldn’t be an issue and no real users are affected.

For testing purposes, everyone will need to establish new accounts. Account creation system has been reset to allow all already registered social logins to claim free accounts.

@Montoya Montoya merged commit 8d3d769 into main Dec 12, 2024
16 checks passed
@Montoya Montoya deleted the newEOS branch December 12, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Snap] EOS Wallet
4 participants