Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump {profile-sync,notification-services}-controller #12615

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

cryptodev-2s
Copy link
Contributor

@cryptodev-2s cryptodev-2s commented Dec 9, 2024

Description

We want to ensure that mobile is using the latest versions of all controllers.

  • Bump @metamask/notification-services-controller from 0.14.0 to 0.15.0 (view changes)
    • There are no notable changes between these versions.
  • Bump @metamask/profile-sync-controller from 2.0.0 to 3.0.0 (view changes)
    • The UserStorageController messenger must now allow the actions NetworkController:getState, NetworkController:addNetwork, NetworkController:removeNetwork, and NetworkController:updateNetwork
    • The UserStorageController messenger must now allow the event NetworkController:networkRemoved

Related issues

Fixes: #12514

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cryptodev-2s cryptodev-2s self-assigned this Dec 9, 2024
@cryptodev-2s cryptodev-2s requested review from a team as code owners December 9, 2024 19:25
@cryptodev-2s cryptodev-2s marked this pull request as draft December 9, 2024 19:25
Copy link
Contributor

github-actions bot commented Dec 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@cryptodev-2s cryptodev-2s added the Run Smoke E2E Triggers smoke e2e on Bitrise label Dec 9, 2024
Copy link
Contributor

github-actions bot commented Dec 9, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 75ebe9a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9108d4a0-1756-43f3-be47-0c675292e2f8

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

socket-security bot commented Dec 9, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] network 0 1.37 MB metamaskbot
npm/@metamask/[email protected] network 0 1.35 MB metamaskbot

🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected]

View full report↗︎

@cryptodev-2s cryptodev-2s changed the title chore: bump {profile-sync,notification-service}-controller chore: bump {profile-sync,notification-services}-controller Dec 9, 2024
@cryptodev-2s cryptodev-2s requested review from a team December 9, 2024 19:43
@cryptodev-2s cryptodev-2s marked this pull request as ready for review December 9, 2024 19:45
Copy link
Contributor

@Prithpal-Sooriya Prithpal-Sooriya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for notifications controller.
@mathieuartu / Identity team is the profile sync controller changes ok?

Copy link
Contributor

@mathieuartu mathieuartu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Owned files LGTM!

@cryptodev-2s cryptodev-2s added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit 8ad0072 Dec 10, 2024
67 checks passed
@cryptodev-2s cryptodev-2s deleted the cryptodev2s/bump-nsc-0.15.0-psc-3.0.0 branch December 10, 2024 15:56
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2024
@metamaskbot metamaskbot added the release-7.38.0 Issue or pull request that will be included in release 7.38.0 label Dec 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.38.0 Issue or pull request that will be included in release 7.38.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-framework
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update metamask/profile-sync-controller to version 3.0.0
5 participants