-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump {profile-sync,notification-services}-controller #12615
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise✅✅✅ Commit hash: 75ebe9a Note
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for notifications controller.
@mathieuartu / Identity team is the profile sync controller changes ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Owned files LGTM!
Quality Gate passedIssues Measures |
Description
We want to ensure that mobile is using the latest versions of all controllers.
@metamask/notification-services-controller
from 0.14.0 to 0.15.0 (view changes)@metamask/profile-sync-controller
from 2.0.0 to 3.0.0 (view changes)UserStorageController
messenger must now allow the actionsNetworkController:getState
,NetworkController:addNetwork
,NetworkController:removeNetwork
, andNetworkController:updateNetwork
UserStorageController
messenger must now allow the eventNetworkController:networkRemoved
Related issues
Fixes: #12514
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist