fix: Type fixes and optimizations for EngineService, Redux store

[MajorLift]

Description

• Define types: ReduxStore, ReduxState -> Fix any types in EngineService.
• Optimize EngineService event subscriptions:
  • Fix update_bg_state_cb callback being re-defined on every iteration.
  • Consolidate stateChange events collections into BACKGROUND_STATE_CHANGE_EVENT_NAMES constant for maintainability.

Related issues

• Blocked by chore(deps): Bump @metamask/composable-controller from ^3.0.0 to ^9.1.0 #10441
  • Blocked by [composable-controller] perf: Optimize expensive reduce operations, fix metadata instantiation core#4968 and corresponding release.

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 3ade7e5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d0599fd7-72fb-43d3-918c-5ee7e98c0302

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: abe850b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7897da3f-271f-4aab-9b8c-ec5b13adddb9

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[github-actions]

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 61588b4
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8db9856d-bfcb-418d-bf04-02cf9a3d8521

Note

• This comment will auto-update when build completes
• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: d0523b0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9affc9ef-17ee-44ae-a472-a33d25250a46

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ff2ee98
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/77ff84ab-8629-48ef-8484-b730c36715ed

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 0bd86a1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/de56888a-7e95-4f78-9e8b-02c766bc6e99

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 57d7919
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fce9e03a-61a0-4765-be49-304c94035967

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[sonarcloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud