feat: add aggregated portfolio balance cross chains #12505

sahar-fehri · 2024-12-02T09:07:47Z

Description

PR that adds cross chain aggregated balance display on main wallet view and in account picker component.

This branch was created from salim/multichain-detect-tokens-feat

Related issues

Fixes:

Manual testing steps

Build using PORTFOLIO_VIEW flag

PORTFOLIO_VIEW=true yarn watch
yarn start:ios

Go to main page and see the network filter
Click on current network and notice that you see aggregated balance in fiat (native balance in fiat + token balances in fiat)
Click on all Networks and notice that the aggregated fiat balance changes to the sum of all (token + native) fiat values of all networks
Click on Account picker and you should see correct aggregated balances

Screenshots/Recordings

Before

After

Screen.Recording.2024-12-03.at.00.45.10.mov

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-12-02T09:08:02Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions · 2024-12-02T23:55:09Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a4b9b7e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2e71277a-2b59-4eb8-93e8-d0303b6f5598

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

salimtb · 2024-12-03T11:55:01Z

i just did some QA, works as expected. Here are the tests I performed:

Adding or deleting a network with funds updates the aggregated balance.
Adding or removing tokens with funds adjusts the aggregated balance.
Switching accounts reflects a change in the aggregated balance.
The balance displayed in the account selector is accurate.
Performing a send operation updates the balance accordingly.

Tests not yet conducted:

Swapping tokens and verifying the impact on the aggregated balance.
Using the ramp flow to buy tokens and confirming the aggregated balance updates.

github-actions · 2024-12-03T12:24:12Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 741c585
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/27ade8ac-6d76-4703-9665-f51568ae9318

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2024-12-03T13:03:03Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b74da86
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2226a742-42e0-41da-a975-8ae96926acd1

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2024-12-03T20:22:42Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 156924f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c076ee69-4748-49be-9b40-cf14ec3c22dc

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sonarcloud · 2024-12-03T20:32:20Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

gambinish · 2024-12-03T23:11:49Z

...onent-library/components-temp/Price/AggregatedPercentage/AggregatedPercentageCrossChains.tsx

+    <View style={styles.wrapper}>
+      <SensitiveText
+        isHidden={privacyMode}
+        length="10"


Weird that this is a string and not a number isn't it?

gambinish · 2024-12-03T23:14:14Z

app/components/UI/Tokens/TokenList/PortfolioBalance/index.tsx

+    if (isPortfolioViewEnabled) {
+      total = totalFiatBalance ?? 0;
+    } else {
+      const tokenFiatTotal = balance?.tokenFiat ?? 0;
+      const ethFiatTotal = balance?.ethFiat ?? 0;
+      total = tokenFiatTotal + ethFiatTotal;
+    }
+  } else if (isPortfolioViewEnabled) {
+    total = totalTokenFiat ?? 0;


Hopefully we can remove these isPortfolioViewEnabled checks not long after release. We should probably do this for extension too once the feature is deemed stable.

I would hate for these checks to be long lived on production

gambinish · 2024-12-03T23:58:04Z

app/selectors/networkController.ts

@@ -160,7 +160,7 @@ export const selectNetworkClientId = createSelector(

 export const selectIsAllNetworks = createSelector(
  selectNetworkConfigurations,
-  selectTokenNetworkFilter,
+  (state: RootState) => selectTokenNetworkFilter(state),


Can you help me understand this change? I'm not sure if I've seen this pattern before.

gambinish

LGTM ✅

salimtb force-pushed the salim/multichain-detect-tokens-feat branch from 6878c10 to ea8ee34 Compare December 2, 2024 09:57

sahar-fehri marked this pull request as ready for review December 2, 2024 23:47

sahar-fehri requested review from a team as code owners December 2, 2024 23:47

sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise team-assets needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. portfolio-view Used for PRs and issues related to Q4 2024 portfolio view labels Dec 2, 2024

sahar-fehri requested a review from a team as a code owner December 3, 2024 12:16

sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 3, 2024

Base automatically changed from salim/multichain-detect-tokens-feat to main December 3, 2024 17:01

feat: aggregated balance cross chains for portfolio view

156924f

sahar-fehri force-pushed the feat/cross-chain-aggregated-balance-feature branch from 5808bd1 to 156924f Compare December 3, 2024 20:20

sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 3, 2024

gambinish reviewed Dec 3, 2024

View reviewed changes

gambinish approved these changes Dec 4, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add aggregated portfolio balance cross chains #12505

feat: add aggregated portfolio balance cross chains #12505

sahar-fehri commented Dec 2, 2024 •

edited

Loading

github-actions bot commented Dec 2, 2024

github-actions bot commented Dec 2, 2024 •

edited by metamaskbot

Loading

salimtb commented Dec 3, 2024

github-actions bot commented Dec 3, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Dec 3, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Dec 3, 2024 •

edited by metamaskbot

Loading

sonarcloud bot commented Dec 3, 2024

gambinish Dec 3, 2024

gambinish Dec 3, 2024 •

edited

Loading

gambinish Dec 3, 2024

gambinish Dec 3, 2024

gambinish left a comment

feat: add aggregated portfolio balance cross chains #12505

Are you sure you want to change the base?

feat: add aggregated portfolio balance cross chains #12505

Conversation

sahar-fehri commented Dec 2, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Dec 2, 2024

github-actions bot commented Dec 2, 2024 • edited by metamaskbot Loading

Bitrise

salimtb commented Dec 3, 2024

github-actions bot commented Dec 3, 2024 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Dec 3, 2024 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Dec 3, 2024 • edited by metamaskbot Loading

Bitrise

sonarcloud bot commented Dec 3, 2024

Quality Gate passed

gambinish Dec 3, 2024

Choose a reason for hiding this comment

gambinish Dec 3, 2024 • edited Loading

Choose a reason for hiding this comment

gambinish Dec 3, 2024

Choose a reason for hiding this comment

gambinish Dec 3, 2024

Choose a reason for hiding this comment

gambinish left a comment

Choose a reason for hiding this comment

sahar-fehri commented Dec 2, 2024 •

edited

Loading

github-actions bot commented Dec 2, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Dec 3, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Dec 3, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Dec 3, 2024 •

edited by metamaskbot

Loading

gambinish Dec 3, 2024 •

edited

Loading