feat: Support gas fee flows in swaps #12495
Conversation
|
OGPoyraz
added
Run Smoke E2E
|
|
| let tradeGasFeeEstimates; | ||
| const tradeTransaction = selectedQuote.trade; | ||
|
|
||
| if (isEIP1559Network) { |
There was a problem hiding this comment.
Minor, is it worth encapsulating all this logic in the existing getTransactionPropertiesFromGasEstimates but also passing the quote argument?
|
|
||
| let approvalGasFeeEstimates; | ||
|
|
||
| if (isEIP1559Network) { |
There was a problem hiding this comment.
If we expanded getTransactionPropertiesFromGasEstimates, could we just call again here but with the approval transaction or quote instead?
|
|
||
| const { TransactionController } = Engine.context; | ||
|
|
||
| const transactionGasFeeResponse = await TransactionController.estimateGasFee({ |
There was a problem hiding this comment.
Should we use the transaction controller utils file here instead?
| @@ -156,3 +156,11 @@ export const selectNetworkClientId = createSelector( | |||
| (networkControllerState: NetworkState) => | |||
| networkControllerState.selectedNetworkClientId, | |||
| ); | |||
|
|
|||
| export const selectIsEIP1559Network = createSelector( | |||
There was a problem hiding this comment.
We could also determine this from the gas fee estimate type, but this is better as it reduces coupling on the gas fee controller ❤️
|
|
||
| const mockSelectedNetworkClientId = '1'; | ||
|
|
||
| describe('NetworkController Selectors', () => { |
There was a problem hiding this comment.
Minor, but Redux discourage testing unit selectors in favour of mocking state in all component and hook tests so they get covered there.
| const { maxFeePerGas } = transactionGasFeeEstimates?.high ?? {}; | ||
| const { maxPriorityFeePerGas } = transactionGasFeeEstimates?.high ?? {}; | ||
|
|
||
| const baseAndPriorityFeePerGas = maxPriorityFeePerGas |
There was a problem hiding this comment.
Is this needed in mobile since we add this return straight to the transaction params? And estimatedBaseFeeGwei also?
|
Tested and seems to be working |
Description
This PR aims to adapt
estimateGasFeefromTransactionControllerfor swapstradeandapprovaltransactions. For more information please see the extension PR applies same functionality: MetaMask/metamask-extension#27612Also adding basic unit tests for
QuoteViewscreen.Related issues
Fixes: https://github.com/MetaMask/mobile-planning/issues/2026
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist