-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ramp): estimate gasLimit for ERC20 transfers (sell feature) #12467
base: main
Are you sure you want to change the base?
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12467 +/- ##
==========================================
+ Coverage 56.41% 56.96% +0.55%
==========================================
Files 1797 1816 +19
Lines 40586 40899 +313
Branches 5097 5172 +75
==========================================
+ Hits 22896 23298 +402
+ Misses 16134 16016 -118
- Partials 1556 1585 +29 ☔ View full report in Codecov by Sentry. |
…MetaMask/metamask-mobile into feat/ramps-erc20-gas-estimation
…to feat/ramps-erc20-gas-estimation
Bitrise❌❌❌ Commit hash: 28f67a9 Note
Tip
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Bitrise✅✅✅ Commit hash: 39b6782 Note
|
Quality Gate passedIssues Measures |
Previously, we only estimated the gas limit for native token transactions. Now, we’ve added functionality to be able to estimate the gas limit for ERC20 token transfers during the sell operation.
This limit is then provided to the hook that estimates the total gas price.
We still use the default native token gas limit as a fallback (21,000 units).
Description
This is necessary to enable the sell feature with tokens other than the native chain token on mobile.
Related issues
https://consensyssoftware.atlassian.net/browse/RAMPS-2042?atlOrigin=eyJpIjoiNWUyZmVmNDY3MzcyNGE1NGJkZDVjM2RjNTM4MzgxNDkiLCJwIjoiaiJ9
Manual testing steps
Screenshots/Recordings
NA
Before
NA
After
NA
Pre-merge author checklist
Pre-merge reviewer checklist