Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade profile-sync-controller to 1.0.0 #12459

Merged
merged 8 commits into from
Dec 3, 2024
Merged

feat: upgrade profile-sync-controller to 1.0.0 #12459

merged 8 commits into from
Dec 3, 2024
+33 −26

Conversation

Prithpal-Sooriya
Copy link
Contributor

Description

Upgrades @metamask/profile-sync-controller to ^1.0.0

This should be a smooth upgrade since the controller is currently unused in mobile (disabled behind a flag)

Related issues

Fixes: #12306

Manual testing steps

N/A - this is purely a package upgrade with no additional changes.

Just ensure that we can start up the application without any issues.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-notifications Notifications team label Nov 27, 2024
@socket-security Socket Security
Copy link

socket-security bot commented Nov 27, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] network Transitive: environment +1 1.82 MB metamaskbot

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

mathieuartu
mathieuartu previously approved these changes Nov 27, 2024
View reviewed changes
@Prithpal-Sooriya Prithpal-Sooriya added the Run Smoke E2E Triggers smoke e2e on Bitrise label Nov 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 27, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a240dc8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/00442587-6d91-49d2-888a-fa615dc518c1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Prithpal-Sooriya Prithpal-Sooriya added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 28, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d1e7f31
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/12c5e618-7cbf-43d9-a22b-4e7110ab1d9c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Prithpal-Sooriya Prithpal-Sooriya added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 28, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 3041830
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e8cb2edc-8245-4152-a17e-d7566c1ed253

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Prithpal-Sooriya Prithpal-Sooriya added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 29, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1e0fcc4
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/551f2cd1-1709-4880-aa13-9b20f74f839b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Prithpal-Sooriya Prithpal-Sooriya added this pull request to the merge queue Dec 3, 2024
Merged via the queue into main with commit 57da0a9 Dec 3, 2024
37 checks passed
@Prithpal-Sooriya Prithpal-Sooriya deleted the feat/upgrade-profile-sync-controller branch December 3, 2024 14:36
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2024
@metamaskbot metamaskbot added the release-7.38.0 Issue or pull request that will be included in release 7.38.0 label Dec 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tommasini tommasini tommasini approved these changes

@mathieuartu mathieuartu mathieuartu left review comments

Assignees
No one assigned
Labels
release-7.38.0 Issue or pull request that will be included in release 7.38.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-notifications Notifications team
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update metamask/profile-sync-controller to version 1.0.0
4 participants
@Prithpal-Sooriya @mathieuartu @tommasini @metamaskbot