Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/bitcoin bdk #12454

Closed
wants to merge 41 commits into from
Closed

Test/bitcoin bdk #12454

wants to merge 41 commits into from

Conversation

owencraston
Copy link
Contributor

@owencraston owencraston commented Nov 26, 2024

Description

This PR branches off of this PR to test the snap that runs the Bitcoin developer kit. I am using this version of the snap that @darioAnongba created to test the BDK.

Currently BDK is not working on iOS and is throwing the following error...

MetaMask DEBUG]: [Error: Error while running snap 'npm:@metamask/bitcoin-wallet-snap': undefined is not an object (evaluating 'new WebAssembly.Module')]

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 9.79 kB pur3miish
npm/[email protected] None 0 35.5 kB ruigomes
npm/[email protected] None 0 23.4 kB kawanet

View full report↗︎

@owencraston owencraston changed the base branch from main to feat/bitcoin-wallet-overview November 26, 2024 23:59
Copy link

sonarcloud bot commented Nov 27, 2024

@owencraston owencraston force-pushed the feat/bitcoin-wallet-overview branch 4 times, most recently from 6bd0b2a to b5a005e Compare December 2, 2024 18:42
Base automatically changed from feat/bitcoin-wallet-overview to main December 2, 2024 20:21
@owencraston owencraston closed this Dec 6, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants