Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multi chain asset list #12431

Open
wants to merge 48 commits into
base: main
Choose a base branch
from
Open

feat: multi chain asset list #12431

wants to merge 48 commits into from

Conversation

vinnyhoward
Copy link
Contributor

@vinnyhoward vinnyhoward commented Nov 26, 2024

Description

This PR introduces the Unified Asset List feature to MetaMask Mobile, providing users with a consolidated view of their assets across all supported blockchain networks. This enhancement improves the user experience by eliminating the need to switch between networks to view or manage assets, making asset management more intuitive and efficient.

Related issues

Fixes: #12462

Manual testing steps

  1. Go to the wallet page
  2. select all network on the network filter
  3. check the list of assets

Screenshots/Recordings

NA

Before

NA

After

after.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vinnyhoward vinnyhoward added No QA Needed Apply this label when your PR does not need any QA effort. team-assets No E2E Smoke Needed If the PR does not need E2E smoke test run team-wallet-ux labels Nov 26, 2024
@vinnyhoward vinnyhoward requested review from a team as code owners November 26, 2024 15:11
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vinnyhoward vinnyhoward added the portfolio-view Used for PRs and issues related to Q4 2024 portfolio view label Nov 26, 2024
@vinnyhoward vinnyhoward requested review from a team as code owners November 27, 2024 03:56
@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed No E2E Smoke Needed If the PR does not need E2E smoke test run Run Smoke E2E Triggers smoke e2e on Bitrise No QA Needed Apply this label when your PR does not need any QA effort. labels Dec 2, 2024
Copy link
Contributor

github-actions bot commented Dec 2, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 32db30a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9768b737-0bce-4dd9-b79c-f896e495e3f7

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 2, 2024
@salimtb salimtb requested a review from a team as a code owner December 3, 2024 15:00
Base automatically changed from salim/multichain-detect-tokens-feat to main December 3, 2024 17:01
@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 3, 2024
Copy link
Contributor

github-actions bot commented Dec 3, 2024

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 58c95e6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ec76f556-3ce0-41b8-a216-538974d9a9ef

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 3, 2024
Copy link
Contributor

github-actions bot commented Dec 3, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a7641c8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4272b306-6a72-48e3-8bbe-7af929191e9c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@vinnyhoward vinnyhoward added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 3, 2024
Copy link
Contributor

github-actions bot commented Dec 3, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 7f825dd
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0aae7efc-33eb-4fab-9318-3fb87cbb0a22

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link

sonarcloud bot commented Dec 3, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
portfolio-view Used for PRs and issues related to Q4 2024 portfolio view Run Smoke E2E Triggers smoke e2e on Bitrise team-assets team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile: Portfolio View: Update activity list copy on Token Details
4 participants