Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix typo on MetaMetrics agreement screen #12403

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mcmire
Copy link
Contributor

@mcmire mcmire commented Nov 22, 2024

Description

It's important that we spell everything correctly on a screen that we want everyone to read.

Related issues

N/A, just something I noticed while using the app locally.

Manual testing steps

  1. Starting from the Welcome screen, tap "Get started".
  2. Tap one of the two options.
  3. On the "Help us improve MetaMask" screen, see that the text next to the checkbox is free of typos.

Screenshots/Recordings

Before

Simulator Screenshot - iPhone 16 Pro - 2024-11-22 at 15 21 50

After

Simulator Screenshot - iPhone 16 Pro - 2024-11-22 at 15 20 05

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

It's important that we spell everything correctly on a screen that we
want everyone to read.
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@mcmire mcmire changed the title Fix typo on MetaMetrics agreement screen fix: Fix typo on MetaMetrics agreement screen Nov 22, 2024
@mcmire mcmire added the No QA Needed Apply this label when your PR does not need any QA effort. label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No QA Needed Apply this label when your PR does not need any QA effort. team-wallet-framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants