Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metamask/profile-sync-controller to version 3.0.0 #12514

Closed
metamaskbot opened this issue Dec 3, 2024 · 0 comments · Fixed by #12615
Closed

Update metamask/profile-sync-controller to version 3.0.0 #12514

metamaskbot opened this issue Dec 3, 2024 · 0 comments · Fixed by #12615
Assignees
Labels
release-7.38.0 Issue or pull request that will be included in release 7.38.0 team-identity team-notifications Notifications team

Comments

@metamaskbot
Copy link
Collaborator

Please update metamask/profile-sync-controller to version 3.0.0

@metamaskbot metamaskbot added the team-notifications Notifications team label Dec 3, 2024
@cryptodev-2s cryptodev-2s self-assigned this Dec 9, 2024
github-merge-queue bot pushed a commit that referenced this issue Dec 10, 2024
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

We want to ensure that mobile is using the latest versions of all
controllers.

- Bump `@metamask/notification-services-controller` from 0.14.0 to
0.15.0 ([view
changes](https://github.com/MetaMask/core/blob/main/packages/notification-services-controller/CHANGELOG.md))
  - There are no notable changes between these versions.
- Bump `@metamask/profile-sync-controller` from 2.0.0 to 3.0.0 ([view
changes](https://github.com/MetaMask/core/blob/main/packages/profile-sync-controller/CHANGELOG.md))
- The `UserStorageController` messenger must now allow the actions
`NetworkController:getState`, `NetworkController:addNetwork`,
`NetworkController:removeNetwork`, and `NetworkController:updateNetwork`
- The `UserStorageController` messenger must now allow the event
`NetworkController:networkRemoved`

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Related issues**

Fixes:
#12514

## **Manual testing steps**

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@metamaskbot metamaskbot added the release-7.38.0 Issue or pull request that will be included in release 7.38.0 label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-7.38.0 Issue or pull request that will be included in release 7.38.0 team-identity team-notifications Notifications team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants