Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metamask/profile-sync-controller to version 1.0.0 #12306

Closed
metamaskbot opened this issue Nov 15, 2024 · 2 comments · Fixed by #12459
Closed

Update metamask/profile-sync-controller to version 1.0.0 #12306

metamaskbot opened this issue Nov 15, 2024 · 2 comments · Fixed by #12459
Assignees
Labels
release-7.38.0 Issue or pull request that will be included in release 7.38.0 team-assets team-identity team-notifications Notifications team

Comments

@metamaskbot
Copy link
Collaborator

Please update metamask/profile-sync-controller to version 1.0.0

@metamaskbot metamaskbot added the team-notifications Notifications team label Nov 15, 2024
@Prithpal-Sooriya
Copy link
Contributor

@mathieuartu ping to upgrade mobile profile sync controller.
Happy to assist on this.

@Prithpal-Sooriya
Copy link
Contributor

Prithpal-Sooriya commented Nov 27, 2024

OK we can safely upgrade to 1.0.0

We cannot upgrade to 2.0.0 until other peer dependencies are updated:
https://github.com/MetaMask/core/blob/main/packages/profile-sync-controller/CHANGELOG.md#200

That can be done in a separate PR

@Prithpal-Sooriya Prithpal-Sooriya self-assigned this Nov 27, 2024
github-merge-queue bot pushed a commit that referenced this issue Dec 3, 2024
## **Description**

Upgrades `@metamask/profile-sync-controller` to `^1.0.0`

This should be a smooth upgrade since the controller is currently unused
in mobile (disabled behind a flag)

## **Related issues**

Fixes: #12306

## **Manual testing steps**

N/A - this is purely a package upgrade with no additional changes.

Just ensure that we can start up the application without any issues.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@metamaskbot metamaskbot added the release-7.38.0 Issue or pull request that will be included in release 7.38.0 label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-7.38.0 Issue or pull request that will be included in release 7.38.0 team-assets team-identity team-notifications Notifications team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants