Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: async key exchange #182

Merged
merged 2 commits into from
Sep 9, 2024
Merged

feat: async key exchange #182

merged 2 commits into from
Sep 9, 2024

Conversation

elefantel
Copy link
Contributor

@elefantel elefantel commented Sep 4, 2024

This PR implements an asynchronous key exchange with MetaMask wallet, which simplifies the key exchange process and improves the connection between the dapp and the wallet.

Demo:

deeplinking.MP4
async.key.exchange.mp4

@elefantel elefantel requested a review from a team as a code owner September 4, 2024 11:37
@elefantel elefantel self-assigned this Sep 4, 2024
Copy link

sonarqubecloud bot commented Sep 4, 2024

@christopherferreira9
Copy link
Collaborator

Looks good for testing!

Copy link
Contributor

@abretonc7s abretonc7s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but not sure how connectWith is handled here?

@elefantel
Copy link
Contributor Author

LGTM but not sure how connectWith is handled here?

The request is passed to connectWith method here and the rpc added to the deeplink here

@elefantel elefantel merged commit 1d440a2 into main Sep 9, 2024
2 checks passed
@elefantel elefantel deleted the async-key-exchange branch September 9, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants