Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: log done request for all responses #166

Merged
merged 2 commits into from
Jul 10, 2024
Merged

chore: log done request for all responses #166

merged 2 commits into from
Jul 10, 2024

Conversation

elefantel
Copy link
Contributor

This PR ensures that all request-response events are logged for SDK_RPC_REQUEST_DONE. Previously, only success responses were logged.

@elefantel elefantel self-assigned this Jul 10, 2024
@elefantel elefantel requested a review from a team as a code owner July 10, 2024 06:56
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

andreahaku
andreahaku approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elefantel elefantel merged commit 48e3d1a into main Jul 10, 2024
2 checks passed
@elefantel elefantel deleted the rpc-request-done branch July 10, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreahaku andreahaku andreahaku approved these changes

Assignees

@elefantel elefantel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elefantel @andreahaku