Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: session persistence v2 support #164

Merged
merged 4 commits into from
Jul 3, 2024
Merged

feat: session persistence v2 support #164

merged 4 commits into from
Jul 3, 2024

Conversation

elefantel
Copy link
Contributor

@elefantel elefantel commented Jul 1, 2024

This PR adds support for session persistence v2 protocol, whereby the encryption keys for the client to decrypt data and the server public key to encrypt data are stored in the secure enclave (keychain) and reused for future interactions.

The attached video is a demo for this feature, demonstrating how the wallet is able to handle dapp requests even after it was killed without requiring a connection request.

v2protocol.mov

@elefantel elefantel self-assigned this Jul 1, 2024
@elefantel elefantel requested a review from a team as a code owner July 1, 2024 09:07
@elefantel elefantel marked this pull request as draft July 1, 2024 09:07
@elefantel elefantel changed the title feat: async comm feat: async communication Jul 1, 2024
@elefantel elefantel marked this pull request as ready for review July 3, 2024 08:41
Copy link

sonarqubecloud bot commented Jul 3, 2024

@elefantel elefantel changed the title feat: async communication feat: session persistence v2 support Jul 3, 2024
Copy link
Contributor

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elefantel elefantel merged commit fa084d8 into main Jul 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants