filters bug fix

[kumavis]

relevant change
MetaMask/eth-json-rpc-filters@d9e5694
MetaMask/eth-json-rpc-filters@f804d9a
MetaMask/json-rpc-engine@091b355

not certain if this fixes all the issues with events/logs/filters but it should help

Updates #2393
Updates #2255
Updates #2114

[kumavis]

unrelated security failure:

Vulnerable: <=1.1.1 - Patched: >=2.0.0 - Path: [email protected] > [email protected] > [email protected] > [email protected]

[frankiebee]

LGTM as well as confirmation from user who had initial issue that this is fixed

[maxsupera]

Hey there. I believe this was also going to fix metamask listening to contract events. The 'transfer' event works fine for me if I dont use metamask and specify the web3 provider myself (localhost or infura). However, as soon as I try using metamask instead, the contract event is no longer listened to... Even with this new update, im still experiencing this problem.

Im building with react and listening to the transfer event in 'componentDidMount', and making sure web3 is provided by metamask beforehand.

Any help is much appreciated. Id like to be able to use this in production. Thanks!!

[nteymory]

Just wanted to note that this change didn't fix listening to contract events (#2393) This still doesn't work in version 3.12.0

[nteymory]

I am having trouble reproducing this bug since 3.14.1, it may have been fixed, or at least improved since 3.12? So, I cannot confirm whether this change makes a difference.

EDIT: My bad, I was performing my test incorrectly. Watching was fixed for pre-existing events, But new events produced while watching still wouldn't work. @lazaridiscom I tested your change, and it appears to fix this problem!