Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Yarn v3 #119

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Upgrade to Yarn v3 #119

merged 1 commit into from
Feb 6, 2024

Conversation

mcmire
Copy link
Contributor

@mcmire mcmire commented Feb 2, 2024

  • Use Yarn 3.2.1 as designated by the module template
  • Regenerate yarn.lock using Yarn v3
  • Replace prepublishOnly package script with prepack, and add scripts/prepack.sh from the module template
  • Run yarn dedupe when running yarn lint
  • Remove yarn setup as yarn install automatically runs yarn allow-scripts

Copy link

socket-security bot commented Feb 2, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +70 12 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment +10 191 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 64.6 kB nicolo-ribaudo
npm/@babel/[email protected] environment, filesystem, unsafe Transitive: shell +52 10.8 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment +10 3.38 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment +4 2.5 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment +4 2.51 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, shell +12 2.59 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, shell, unsafe +64 11.6 MB nicolo-ribaudo
npm/@babel/[email protected] unsafe Transitive: environment, filesystem, shell +61 11.2 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment +4 2.55 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment +4 2.55 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, shell, unsafe +52 10.8 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment +4 2.5 MB nicolo-ribaudo
npm/@babel/[email protected] None 0 11.9 kB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, shell, unsafe +55 10.8 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, shell, unsafe +55 10.9 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment +4 2.51 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment +4 2.5 MB nicolo-ribaudo
npm/@babel/[email protected] None 0 31.6 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 11.7 kB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment +17 4.62 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment +31 6.81 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment +9 168 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 1.88 MB nicolo-ribaudo
npm/@babel/plugin-bugfix-safari-id-destructuring-collision-in-function-expression@7.23.3 Transitive: environment, filesystem, shell, unsafe +54 10.8 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, shell, unsafe +55 10.8 MB nicolo-ribaudo
npm/@babel/plugin-proposal-private-property-in-object@7.21.0-placeholder-for-preset-env.2 Transitive: environment, filesystem, shell, unsafe +53 10.8 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, shell, unsafe +54 10.8 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, shell, unsafe +54 10.8 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, shell, unsafe +57 10.8 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, shell, unsafe +54 10.8 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, shell, unsafe +54 10.9 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, shell, unsafe +58 11 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, shell, unsafe +54 10.8 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, shell, unsafe +54 10.9 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, shell, unsafe +66 11.6 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, shell, unsafe +54 10.8 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, shell, unsafe +55 10.8 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, shell, unsafe +55 10.8 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, shell, unsafe +54 10.8 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, shell, unsafe +54 10.8 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, shell, unsafe +54 10.8 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, shell, unsafe +54 10.8 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, shell, unsafe +54 10.8 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, shell, unsafe +54 10.8 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, shell, unsafe +54 10.8 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, shell, unsafe +66 11.6 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, shell, unsafe +54 10.8 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, shell, unsafe +57 10.9 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, shell, unsafe +54 10.8 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, shell, unsafe +54 10.8 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, shell, unsafe +57 11.2 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, shell, unsafe +54 10.8 MB nicolo-ribaudo
npm/@babel/[email protected] unsafe Transitive: environment, filesystem, shell +66 12.3 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, shell, unsafe +54 10.8 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, shell, unsafe +55 10.8 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, shell, unsafe +54 10.8 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, shell, unsafe +54 10.8 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, shell, unsafe +54 10.8 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, shell, unsafe +54 10.8 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, shell, unsafe +66 11.6 MB nicolo-ribaudo
npm/@babel/[email protected] environment Transitive: filesystem, shell, unsafe +140 14.7 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment, filesystem, shell, unsafe +55 10.9 MB nicolo-ribaudo
npm/@babel/[email protected] None +1 277 kB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment +15 4.59 MB nicolo-ribaudo
npm/@babel/[email protected] Transitive: environment +30 6.22 MB nicolo-ribaudo
npm/@babel/[email protected] environment +3 2.49 MB nicolo-ribaudo
npm/@isaacs/[email protected] None +13 259 kB isaacs
npm/@jridgewell/[email protected] None 0 55.2 kB jridgewell
npm/@jridgewell/[email protected] None +2 265 kB jridgewell
npm/@metamask/[email protected] Transitive: environment, network +24 4.74 MB brad.decker, danfinlay, gudahtt, ...9 more
npm/@metamask/[email protected] Transitive: environment, network +23 4.71 MB brad.decker, danfinlay, gudahtt, ...9 more
npm/@metamask/[email protected] Transitive: environment, network +21 4.61 MB metamaskbot
npm/@metamask/[email protected] Transitive: environment, network +19 4.48 MB metamaskbot
npm/@noble/[email protected] None +1 2.15 MB paulmillr
npm/@noble/[email protected] None 0 761 kB paulmillr
npm/@npmcli/[email protected] Transitive: environment, network +9 478 kB fritzy, gar, lukekarrys, ...2 more
npm/@pkgjs/[email protected] None 0 74.2 kB oss-bot
npm/@scure/[email protected] None 0 79.4 kB paulmillr
npm/@scure/[email protected] None +3 2.29 MB paulmillr
npm/@scure/[email protected] None +2 1.21 MB paulmillr
npm/@types/[email protected] None +1 9.65 kB types
npm/@types/[email protected] None 0 3.2 kB types
npm/@types/[email protected] None 0 3.99 MB types
npm/[email protected] Transitive: environment +2 49.2 kB tootallnate
npm/[email protected] Transitive: eval +43 3.06 MB ljharb
npm/[email protected] None 0 20.4 kB ljharb
npm/[email protected] Transitive: environment, filesystem, shell, unsafe +62 11.3 MB nicolo-ribaudo
npm/[email protected] Transitive: environment, filesystem, shell, unsafe +63 12.1 MB nicolo-ribaudo
npm/[email protected] Transitive: environment, filesystem, shell, unsafe +62 11.2 MB nicolo-ribaudo
npm/[email protected] environment, filesystem Transitive: shell +6 2.36 MB ai
npm/[email protected] Transitive: eval +4 125 kB ljharb
npm/[email protected] None 0 1.96 MB caniuse-lite
npm/[email protected] None 0 15.9 kB phated
npm/[email protected] Transitive: environment, filesystem, shell +7 3.06 MB zloirock
npm/[email protected] environment, filesystem, shell +5 52.1 kB satazor
npm/[email protected] Transitive: eval +38 975 kB ljharb
npm/[email protected] Transitive: eval +6 154 kB ljharb
npm/[email protected] None 0 13.6 kB komagata
npm/[email protected] None 0 272 kB kilianvalkhof
npm/[email protected] Transitive: eval +42 3.03 MB ljharb
npm/[email protected] Transitive: eval +11 251 kB ljharb
npm/[email protected] filesystem 0 11.6 kB lukeed
npm/[email protected] Transitive: environment, network +27 4.81 MB lgbot
npm/[email protected] None +5 2.74 MB alcuadrado, paulmillr
npm/[email protected] shell Transitive: environment, filesystem +7 189 kB isaacs
npm/[email protected] Transitive: eval +42 3.03 MB ljharb
npm/[email protected] eval +3 104 kB ljharb
npm/[email protected] Transitive: eval +5 148 kB ljharb
npm/[email protected] Transitive: eval +4 115 kB ljharb
npm/[email protected] None +1 38.2 kB ljharb
npm/[email protected] Transitive: eval +7 257 kB ljharb
npm/[email protected] Transitive: eval +5 143 kB ljharb
npm/[email protected] Transitive: eval +11 278 kB ljharb
npm/[email protected] environment +15 586 kB isaacs
npm/[email protected] None 0 53.1 kB emn178
npm/[email protected] environment, filesystem 0 13.4 kB mafintosh
npm/[email protected] None 0 34 kB chicoxyzzy
npm/[email protected] None 0 97.2 kB ljharb
npm/[email protected] Transitive: eval +8 248 kB ljharb
npm/[email protected] None 0 4.55 kB sindresorhus
npm/[email protected] filesystem +2 1.27 MB isaacs
npm/[email protected] None 0 5.21 kB lukekarrys
npm/[email protected] None 0 27.9 kB benjamn
npm/[email protected] None +2 412 kB benjamn
npm/[email protected] Transitive: eval +8 214 kB ljharb
npm/[email protected] Transitive: eval +7 183 kB ljharb
npm/[email protected] None +1 5.38 kB kevva
npm/[email protected] None 0 2.83 kB sindresorhus
npm/[email protected] None +3 50.5 kB kemitchell
npm/[email protected] None 0 3.37 kB kemitchell
npm/[email protected] None +2 27 kB kemitchell
npm/[email protected] None 0 11.8 kB kemitchell
npm/[email protected] Transitive: eval +42 3.03 MB ljharb
npm/[email protected] Transitive: eval +42 3.03 MB ljharb
npm/[email protected] Transitive: eval +42 3.03 MB ljharb
npm/[email protected] Transitive: environment, eval, filesystem +74 4.14 MB domenic, ljharb, raynos
npm/[email protected] filesystem, shell Transitive: environment +6 2.36 MB ai
npm/[email protected] Transitive: eval +10 254 kB ljharb

🚮 Removed packages: npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@jridgewell/[email protected], npm/@noble/[email protected], npm/@noble/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Copy link

socket-security bot commented Feb 2, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
New author npm/[email protected]
Shell access npm/[email protected]
Network access npm/[email protected]
Network access npm/[email protected]
Shell access npm/[email protected]
Shell access npm/[email protected]
New author npm/[email protected]
Network access npm/[email protected]

View full report↗︎

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What is shell access?

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@mcmire
Copy link
Contributor Author

mcmire commented Feb 2, 2024

yarn dedupe currently fails with:

➤ YN0001: │ Error: @metamask/ethjs-rpc@^0.3.0 !0.3.1 isn't supported by any available resolver

This should be resolved in #117.

Base automatically changed from add-allow-scripts to main February 5, 2024 23:26
@mcmire mcmire force-pushed the upgrade-to-yarn-v3 branch from 3961ad8 to ea79f6a Compare February 5, 2024 23:28
- Use Yarn 3.2.1 as designated by the module template
- Regenerate `yarn.lock` using Yarn v3
- Replace `prepublishOnly` package script with `prepack`, and add
  `scripts/prepack.sh` from the module template
- Run `yarn dedupe` when running `yarn lint`
- Remove `yarn setup` as `yarn install` automatically runs `yarn
  allow-scripts`
@mcmire mcmire force-pushed the upgrade-to-yarn-v3 branch from ea79f6a to 868f177 Compare February 5, 2024 23:28
"@babel/plugin-transform-runtime": "^7.5.5",
"@babel/preset-env": "^7.5.5",
"@babel/runtime": "^7.21.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn install seems to have applied this. I guess dependencies are alphabetized in Yarn v3.

@mcmire mcmire marked this pull request as ready for review February 5, 2024 23:30
@mcmire mcmire requested a review from a team as a code owner February 5, 2024 23:30
@mcmire
Copy link
Contributor Author

mcmire commented Feb 6, 2024

Double-checked that this doesn't affect dist/.

@mcmire mcmire merged commit 7956694 into main Feb 6, 2024
14 of 15 checks passed
@mcmire mcmire deleted the upgrade-to-yarn-v3 branch February 6, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants