Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Release to 1.2.0 After October Audit Changes #30

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Update Release to 1.2.0 After October Audit Changes #30

merged 1 commit into from
Oct 31, 2024

Conversation

hanzel98
Copy link
Contributor

What?

  • October Audit 3.2 Selector and Calldata Length (#463)

Why?

  • It was prone to errors when the calldata was not long enough

How?

  • Moved the selector after the calldata length validation

@hanzel98 hanzel98 requested a review from a team as a code owner October 30, 2024 18:26
@hanzel98 hanzel98 merged commit a6de9d6 into main Oct 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylandesrosier dylandesrosier dylandesrosier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanzel98 @dylandesrosier