metaprogramming library (8.20 version) #1122
Merged
+424
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for changing the version! Would it be possible to keep multiple authorship? Although I guess it doesn't matter much, but since Yannick wrote a good chunk of the file… |
|
No problem, how do I set ownership ? |
|
This: https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors |
Co-authored-by: Yannick Forster <[email protected]> Co-authored-by: Théo Winterhalter <[email protected]>
|
@TheoWinterhalter are we ready to merge ? |
|
It's ok for me but since it touches other files, maybe someone else should check too? |
|
Who are you thinking about ? The impact of our changes seems to be minimal, and this PR has been taking a long time already... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #1116 to the 8.20 branch. I also included a fix to
Template.Ast.noccurn_betweenthat had not been backported to 8.20.