Fix quoting and unquoting of primitive strings #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a file in the |
|
Thanks! Once CI goes green I'll squash and merge and cherry-pick the commit over to |
yforster
pushed a commit
to yforster/template-coq
that referenced
this pull request
Oct 30, 2024
* initial fix * update test-suite
yforster
added a commit
that referenced
this pull request
Oct 30, 2024
* initial fix * update test-suite Co-authored-by: MathisBD <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following bug related to quoting primitive strings :
The bug comes from the fact that in template-coq's quoting/unquoting code, the ocaml variable named
tStringis used to refer to two distinct Coq terms :bytestring.string.term.The fix involves changing the names of a couple ocaml variables : see the diff for more info.