Convert CLI interface tests to not use subprocess.run
#970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
7 tasks
jfrost-mo
changed the title
subprocess.run
|
GitHub Copilot was used in this PR. |
This is significantly faster and provides more accurate test coverage than running the commands as subprocessses.
jfrost-mo
force-pushed
the
improve_cli_tests
branch
from
ec50f17 to
90a8d32
Compare
jwarner8
reviewed
Dec 10, 2024
jwarner8
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This no longer uses
subprocess.runfor (almost) all of the tests, which makes it faster and more accurately measured for test coverage.For this the main branch is split into functions in the first commit, then the second commit converts the tests to not use subprocess, and adds a couple extras.
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.