-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mask operators #967
base: main
Are you sure you want to change the base?
Add mask operators #967
Conversation
Three example recipes provided, workflow changes are not part of this pull request and may link to the need to add custom recipes to the workflow. |
9b7afdb
to
33a7ad0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just started reviewing this, looks like a great addition. Thanks for developing this. Think I am a bit unclear about apply_mask and how it interacts with multiple cubes/masks. Once I understand will complete review
8845b53
to
c3c7b0a
Compare
Review comments completed @jfrost-mo and @jwarner8 back to you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looking like a good change. I've left some code comments, but nothing there is particularly fundimental.
I haven't looked at the tests yet; will do that later.
Converting to draft to remove all CubeList functionality as there is starting to be operator purpose creep. |
Ready for review again following changes to functionality to only be applicable for cubes due to risk of operator creep. Review comments also taken into account @jfrost-mo and @jwarner8. |
Adds a generate and apply mask operator.
Fixes #221
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.