Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create operator to combine Cubes/CubeList into single CubeList #738

Merged
merged 10 commits into from
Jul 25, 2024
Merged

Create operator to combine Cubes/CubeList into single CubeList #738

merged 10 commits into from
Jul 25, 2024

Conversation

jwarner8
Copy link
Contributor

@jwarner8 jwarner8 commented Jul 8, 2024 •
edited
Loading

Fixes #654

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Ensured the pull request title is descriptive.
  • Conda lock files have been updated if dependencies have changed.
  • Attributed any Generative AI, such as GitHub Copilot, used in this PR.
  • Marked the PR as ready to review.

@jwarner8 jwarner8 self-assigned this Jul 8, 2024
@jwarner8 jwarner8 added the enhancement New feature or request label Jul 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024 •
edited
Loading

Coverage

@jwarner8
Copy link
Contributor Author

jwarner8 commented Jul 8, 2024

This was following the logic of the combine constraint operator, and should be very useful in the YAML files where we want to collect up cubes and combine into a cubelist. The operator makes no attempt to concatenate or merge cubes, other than standard iris operations when adding a cube to a cubelist.

@jwarner8
Copy link
Contributor Author

jwarner8 commented Jul 8, 2024

includes additional test for is_transect for 100% coverage in _utils.py

@jwarner8 jwarner8 marked this pull request as ready for review July 8, 2024 13:27
@jwarner8 jwarner8 requested a review from jfrost-mo July 8, 2024 13:27
@jfrost-mo jfrost-mo changed the title Create operator to combine cubes/cubelist into single cubelist Create operator to combine Cubes/CubeList into single CubeList Jul 22, 2024
@jfrost-mo jfrost-mo force-pushed the create_cubelist_operator branch 2 times, most recently from 26fd0c7 to 80a0b06 Compare July 22, 2024 13:48
jfrost-mo
jfrost-mo approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@jfrost-mo jfrost-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I've done some revisions, and moved the code into more appropriate sections, as well as sneaking in some test fixture refactoring.

src/CSET/operators/_utils.py Outdated Show resolved Hide resolved
@jfrost-mo jfrost-mo mentioned this pull request Jul 22, 2024
Merged
7 tasks
@jfrost-mo jfrost-mo force-pushed the create_cubelist_operator branch from 361a93c to 4c08683 Compare July 23, 2024 11:19
@jwarner8
Copy link
Contributor Author

Ready to merge

@jwarner8 jwarner8 merged commit f07cc95 into main Jul 25, 2024
7 checks passed
@jwarner8 jwarner8 deleted the create_cubelist_operator branch July 25, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfrost-mo jfrost-mo jfrost-mo approved these changes

Assignees

@jwarner8 jwarner8

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a cube to cubelist operator
2 participants
@jwarner8 @jfrost-mo