Use cached conda environment for CI #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jfrost-mo
force-pushed
the
342_directly_use_conda_in_actions
branch
6 times, most recently
from
6ddbac9 to
d213d72
Compare
jfrost-mo
force-pushed
the
342_directly_use_conda_in_actions
branch
from
d213d72 to
fc891f4
Compare
This removes a layer of abstraction, and should also speed up the runtime of the CI checks. Fixes #342. * Use cached conda environment for building docs * List out conda env location * Install module before documenting * Try fixing CONDA not being in env context * Directly use conda environment for tests * Install package before testing * Use explicit prefix for conda env This should avoid permission issues when restoring the cache, and also means we no longer need to rely on $CONDA. * Skip conda install if cache restored * Fail fast on partial cache match
jfrost-mo
force-pushed
the
342_directly_use_conda_in_actions
branch
from
fc891f4 to
e75683b
Compare
jwarner8
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #342, and significantly speeds up the tests.
Note
Currently an editable install is used for running the tests. This is undesirable, as it can cause tests to pass when they otherwise wouldn't, but fixing it will have to be done after #337 is merged, as that contains tweaks in that area. This work is tracked separately in #356.