Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix filter operator for filtering cube #258

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Fix filter operator for filtering cube #258

merged 1 commit into from
Nov 17, 2023

Conversation

daflack
Copy link
Contributor

@daflack daflack commented Nov 17, 2023

fixes #256

@daflack daflack added bug Something isn't working small Small issue that should be quick to resolve labels Nov 17, 2023
@daflack daflack added this to the Away day milestone Nov 17, 2023
@daflack daflack requested a review from jfrost-mo November 17, 2023 16:00
@daflack daflack self-assigned this Nov 17, 2023
@github-actions GitHub Actions
Copy link
Contributor

Coverage

jfrost-mo
jfrost-mo approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@jfrost-mo jfrost-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I like that you also added a test for the bug as this will prevent future regressions in future.

@daflack daflack merged commit e9321a1 into main Nov 17, 2023
5 checks passed
@daflack daflack deleted the filter_fix branch November 17, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfrost-mo jfrost-mo jfrost-mo approved these changes

Assignees

@daflack daflack

Labels
bug Something isn't working small Small issue that should be quick to resolve
Projects
None yet
Milestone
Away day
Development

Successfully merging this pull request may close these issues.

Filter operator should handle filtering a single cube
2 participants
@daflack @jfrost-mo