Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support magento 2.2 #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

brosenberger
Copy link

  • add support for php version 7.1.x
  • add support for magento version 2.2

@amenk
Copy link
Member

amenk commented Apr 4, 2020

@brosenberger Sorry for the late response. I was not watching this repo :-( Actually we would drop the PHP constraints and always support Magento's version constraints.
Did you by change test it with even newer versions of Magento?

@brosenberger
Copy link
Author

@amenk no i didn't test it as the shop using it is still not on 2.3

@brosenberger
Copy link
Author

@brosenberger Sorry for the late response. I was not watching this repo :-( Actually we would drop the PHP constraints and always support Magento's version constraints.
Did you by change test it with even newer versions of Magento?

i just added it to a shop with a 2.3.5-p2 and it worked like a charm when leaving out the constraints for the framework and php version

@amenk
Copy link
Member

amenk commented Aug 10, 2020

@brosenberger I think we should remove the PHP constraints and add the current module-bundle constraints as you tested it successful with the current version :) Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants