-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 30 Seconds Mark Countdown in Match Starter and Add Beatmap Status in Map Checker #138
Open
ZeroPyrozen
wants to merge
6
commits into
Meowhal:master
Choose a base branch
from
ZeroPyrozen:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ZeroPyrozen
commented
Jul 4, 2022
- Added 30 seconds mark countdown in match starter if the countdown start from above 35 seconds
- Added beatmap status information (ranked, graveyard, loved, etc) in map checker
Should've made changes and pr'd to dev branch though, but either way it's no big deal. |
xayanide
suggested changes
Jul 10, 2022
Co-Authored-By: Xayanide <[email protected]>
xayanide
suggested changes
Jul 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use single quotes instead of double quotes for the strings for consistency to the other strings using single quotes as well. ESLint should be doing its job.
Co-Authored-By: Xayanide <[email protected]>
xayanide
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.