Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 30 Seconds Mark Countdown in Match Starter and Add Beatmap Status in Map Checker #138

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ZeroPyrozen
Copy link
Contributor

  • Added 30 seconds mark countdown in match starter if the countdown start from above 35 seconds
  • Added beatmap status information (ranked, graveyard, loved, etc) in map checker

@xayanide
Copy link
Contributor

xayanide commented Jul 7, 2022

Should've made changes and pr'd to dev branch though, but either way it's no big deal.

src/plugins/MatchStarter.ts Outdated Show resolved Hide resolved
Co-Authored-By: Xayanide <[email protected]>
Copy link
Contributor

@xayanide xayanide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use single quotes instead of double quotes for the strings for consistency to the other strings using single quotes as well. ESLint should be doing its job.

src/plugins/MatchStarter.ts Outdated Show resolved Hide resolved
src/plugins/MatchStarter.ts Outdated Show resolved Hide resolved
Co-Authored-By: Xayanide <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants