utilize created_at from rustla username api for adding a birthday flair #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on load of username from api, grab the created_at date, compare it to today's YearDay then append a birthday flair if matching. lint errors for shadowing, range simplification, http errors using code, and capitalized error strings
slugalisk
reviewed
Feb 26, 2021
| if err != nil { | ||
| fmt.Println("err4", err) | ||
| return nil, err | ||
| } | ||
|
|
||
| // if now.Day() == t.Day() && now.Month() == t.Month() && now.Year() == t.Year() { |
There was a problem hiding this comment.
the simplified user object needs to be regenerated when this changes. rn it will only work if the user logs in on their birthday and the flair will stay until they log in again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on load of username from api, grab the created_at date, compare it to
today's YearDay then append a birthday flair if matching.
lint errors for shadowing, range simplification, http errors using code,
and capitalized error strings