Fixed Graphite event tagging to account for incorrect Graphite API do…

…cumentation

src/lighter/graphite.py

@@ -2,6 +2,7 @@
 import urllib2
 import socket
 import time
+import re
 import lighter.util as util
 
 class Graphite(object):
@@ -28,10 +29,13 @@ def notify(self, metricname, title, message, tags=[]):
         self._call('/events/', {
             'what': title,
             'data': message,
-            'tags': merged_tags,
+            'tags': ' '.join(self._mangle(tag) for tag in merged_tags),
             'when': now
         })
 
+    def _mangle(self, tag):
+        return re.sub('[\s,]', '_', tag.strip())
+
     def _send(self, address, data):
         if not self._address or not self._url:
             logging.debug('Graphite is not enabled')

src/lighter/test/graphite_test.py

@@ -41,8 +41,9 @@ def testDeployNotify(self, mock_time, mock_socket, mock_jsonRequest):
             'http://localhost:80/events/', method='POST', data={
                 'what': 'Deployed /myproduct/myservice to the default environment',
                 'data': 'Lighter deployed /myproduct/myservice with image meltwater/myservice:latest to default (localhost:8080)',
-                'tags': ['environment:default', 'service:/myproduct/myservice', 'somekey:someval',
-                         'anotherkey:anotherval', 'justakey', 'source:lighter', 'type:change'],
+                'tags':
+                    'environment:default service:/myproduct/myservice somekey:someval anotherkey:anotherval ' +
+                    'justakey es_ca_pe trimwhitespace source:lighter type:change',
                 'when': 1477507464})
 
         self.assertEquals(1, mock_sock.connect.call_count)

src/resources/yaml/integration/graphite-config-tags.yml

@@ -12,3 +12,5 @@ graphite:
     - somekey:someval
     - anotherkey:anotherval
     - justakey
+    - ' es,ca pe '
+    -    trimwhitespace