feat: Custom replication slot name #543
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion.Enhance connection handling with replication=database and dynamic application_name.Validate replication_slot_name format and add to config schema.Provide examples for parallel replication configuration.
edgarrmondragon
added
enhancement
tap_postgres/tap.py
Outdated
Comment on lines
634
to
650
|
|
||
|
|
||
| # Configuration Example for Parallel Replication | ||
|
|
||
| config_1 = { | ||
| "host": "database1.example.com", | ||
| "port": 5432, | ||
| "dbname": "example_db_1", | ||
| "replication_slot_name": "slot_1", | ||
| } | ||
|
|
||
| config_2 = { | ||
| "host": "database2.example.com", | ||
| "port": 5432, | ||
| "dbname": "example_db_2", | ||
| "replication_slot_name": "slot_2", | ||
| } |
There was a problem hiding this comment.
can we remove these examples or perhaps move them to the readme?
…stgres into feature/slot_name
…ill help. Please check before testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #540
client.py
Introduced support for specifying replication_slot_name in the replication logic
Added replication=database to the connection string
Updated application_name
tap.py
Validation for replication_slot_name: <=60 characters, and do not start with pg_.
Added replication_slot_name as a configurable parameter in config_jsonschema, with a default value of "tappostgres".
Passed replication_slot_name to the PostgresConnector.
Added configuration examples
Added test_slot_name.py to the tests folder