Removing 'rawNvConfig' to refrain of unstable NIC states in DPU mode #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heyvister1
force-pushed
the
remove-raw-nv-config
branch
2 times, most recently
from
b1deb06 to
f3ed293
Compare
Pull Request Test Coverage Report for Build 11915792861Details
💛 - Coveralls |
almaslennikov
requested changes
Nov 19, 2024
| @@ -200,15 +199,6 @@ func (v *configValidationImpl) ConstructNvParamMapFromTemplate( | |||
| applyDefaultNvConfigValueIfExists(consts.AtsEnabledParam, desiredParameters, query) | |||
| } | |||
|
|
|||
| for _, rawParam := range template.RawNvConfig { | |||
There was a problem hiding this comment.
Can you comment out these lines and put a TODO to uncomment them once a fix is ready?
| Name: "TEST_P2", | ||
| Value: "test", | ||
| }, | ||
| }, |
There was a problem hiding this comment.
done. Although we can just check this PR changes :-)
heyvister1
force-pushed
the
remove-raw-nv-config
branch
from
f3ed293 to
d83cc64
Compare
e0ne
approved these changes
Nov 19, 2024
heyvister1
force-pushed
the
remove-raw-nv-config
branch
from
d83cc64 to
40efd3e
Compare
…stable state. We should add and fix unstable states on next releases
heyvister1
force-pushed
the
remove-raw-nv-config
branch
from
40efd3e to
bcf085d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing 'rawNvConfig' since it was causing BF3/2 NICs to enter an unstable state once changing NIC mode from NIC to DPU
We should add and fix unstable states on next releases