Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use different node maintenance request names for different nodes #35

Merged

Conversation

almaslennikov
Copy link
Collaborator

To avoid blocking on several nodes while one is updating, we need to use different names for maintenance requests on different nodes

To avoid blocking on several nodes while one is updating,
we need to use different names for maintenance requests
on different nodes

Signed-off-by: Alexander Maslennikov <[email protected]>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11572019025

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 60.201%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/maintenance/maintenancemanager.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
internal/controller/nicdevice_controller.go 5 78.25%
internal/controller/nicconfigurationtemplate_controller.go 6 86.07%
Totals Coverage Status
Change from base Build 11513872292: -0.2%
Covered Lines: 1738
Relevant Lines: 2887

💛 - Coveralls

@almaslennikov almaslennikov merged commit de1a58e into Mellanox:main Oct 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants