Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some of TS typing issues #400

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

azygis
Copy link

@azygis azygis commented Dec 18, 2024

Description

Types for features property is wrong on vector source amongst some other places. This PR is making them right.

Motivation and Context

Fixes #399.

How Has This Been Tested?

vitest and playwright tests have been run. Typings should not impact the functionality itself though.

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Tests
  • Other (Tooling, Dependency Updates, etc.) - TS typings

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I added a new test.

Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for vue3openlayers ready!

Name Link
🔨 Latest commit a0b06a1
🔍 Latest deploy log https://app.netlify.com/sites/vue3openlayers/deploys/6762b8864ca861000724401b
😎 Deploy Preview https://deploy-preview-400--vue3openlayers.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong type on OlSourceVector.features
1 participant