Develop #18
Merged
Develop #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed RBAC test failure by ensuring consistent JWT_SECRET usage during token generation and validation. - Added additional logging in extract_roles to aid debugging token validation. - Refactored RBAC test cases to consistently use 'test_secret' for JWT signing and decoding. - Implemented unit tests for core/pkce.rs to cover: - Valid PKCE verifier generation and challenge validation. - Invalid PKCE verifier length and character handling. - Challenge validation with both correct and incorrect verifiers.
…xtension_grants.rs - Added tests for device code generation and polling in DefaultDeviceFlowHandler: - Test generating device code with valid user code and verification URI. - Test polling device code with valid and invalid device codes. - Added tests for custom grant handling in CustomGrant: - Test handling a valid custom grant and returning a token response. - Test handling unsupported grant types and ensuring appropriate error response.
- Added unit tests to cover success and failure cases for the CustomGrant handler. - Tests verify: - Successful handling of the custom grant type with valid parameters. - Unsupported grant type scenario returns an appropriate error. - Handling of missing parameters for the custom grant type. - Corrected field types in TokenResponse for proper token generation.
- Added unit tests to cover success and failure cases for the CustomGrant handler. - Tests verify: - Successful handling of the custom grant type with valid parameters. - Unsupported grant type scenario returns an appropriate error. - Handling of missing parameters for the custom grant type. - Corrected field types in TokenResponse for proper token generation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.