Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Resupply Smuggler Dialog Formatting #5475

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

IllianiCBT
Copy link
Collaborator

Fixed a missing resource reference in smuggler dialog.

Refactored the message generation to combine the value string directly within the formatted output. This reduces intermediate variables and improves code clarity.
@IllianiCBT IllianiCBT added the Bug label Dec 21, 2024
@IllianiCBT IllianiCBT self-assigned this Dec 21, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.11%. Comparing base (4944a38) to head (08dd0b1).
Report is 44 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5475   +/-   ##
=========================================
  Coverage     10.11%   10.11%           
- Complexity     6071     6074    +3     
=========================================
  Files          1054     1054           
  Lines        140535   140552   +17     
  Branches      20419    20430   +11     
=========================================
+ Hits          14214    14216    +2     
- Misses       124964   124977   +13     
- Partials       1357     1359    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS HammerGS merged commit fe9a00e into MegaMek:master Dec 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants