Renamed Fight, Defense, and Scouting Combat Role Names #5473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced "FIGHTING", "DEFENCE", and "SCOUTING" roles with "BATTLELINE", "GARRISON", and "RECON" across the codebase. Updated all associated methods, UI labels, tooltips, and calculations to align with the new terminology and behavior.
IllianiCBT
added
AtB
StratCon
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5473 +/- ##
=========================================
Coverage 10.11% 10.11%
- Complexity 6071 6073 +2
=========================================
Files 1054 1054
Lines 140535 140556 +21
Branches 20419 20432 +13
=========================================
+ Hits 14214 14217 +3
- Misses 124964 124982 +18
Partials 1357 1357 ☔ View full report in Codecov by Sentry. |
Updated all instances of "IN_RESERVE" to "RESERVE" across the codebase for consistency and simplicity. Adjustments included enums, method names, and references in tooltips, ensuring uniformity in terminology.
|
Addendum: the 'In Reserve' combat role has been renamed to just 'Reserve' |
|
Question: Would "Front Line" be a better term to use than "Battleline"? I'm not really finding anything related to "battleline" in a Google search, yet I've seen "Front Line" mentioned all over. I'm pretty sure I've seen "front line" used quite a bit in BattleTech fiction to describe a formation's purpose, though I can't make any direct citations. |
Updated all references to the BATTLELINE combat role across the codebase to use the new FRONTLINE designation. This change enhances naming clarity and consistency within the code.
HammerGS
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed "Fight", "Defense", and "Scouting" combat roles to
"Battleline""Frontline", "Garrison", and "Recon".Functionality is unchanged
This change is part of a recent effort to implement more immersive language, where possible.