Fixed Monthly Facility Support Point Gains & Added Functionality to Allied Industrial Facilities #5471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revised `AlliedIndustrialFacility` and `AlliedSupplyDepot` to use `monthlySPModifier` for consistency. Updated descriptions to reflect the monthly SP generation for allied logistical support.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5471 +/- ##
============================================
- Coverage 10.11% 10.11% -0.01%
+ Complexity 6071 6070 -1
============================================
Files 1054 1054
Lines 140535 140545 +10
Branches 20419 20423 +4
============================================
Hits 14214 14214
- Misses 124964 124975 +11
+ Partials 1357 1356 -1 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AlliedSupplyDepotwas incorrectly usingweeklySPModifierinstead ofmonthlySPModifierpreventing monthly SP gain. (this is now addressed as part of #5472)I also went ahead and added this benefit to
AlliedIndustrialFacility, as these previously had no functionality.Fixes #3639
Fixes #4036